Re: [a11y-branch] seeking review for bug 44592: a11y init -- was :Re: [evolution-patches] patches for bug 44592:accessibility initializing codes....

[Ettore Perazzoli <ettore ximian com>]

Hi!

On Thu, 2003-06-19 at 00:35, Gilbert Fang wrote:
> I agree very much that makes a11y non-conditional. In addtion, currently
> gtkhtml and gal both build a11y part, so there is no really extra 
> dependency added for evolution. Thus it also make my patch simpler. :-)

OK, great!

> Let me explain it. 

Thanks for the explanation.

> But in fact, it seems gnome can not deal such stuff idealy. That is why
> I have to add explicit initialization code in evolution. 

Is that supposed to be fixed in GNOME proper maybe?

> > 	[init.c]
> >         +       fprintf (stderr, "Evolution Accessibilty Support
> >         Extension Module shutdown\n");
> > 
> > What's the point of these?
> > 
> It just shows the message that can help developer to confirm  the module
> is loaded. Gail, libgail-gnome and atk-bridge all have such output. 
> And I prefer it if it does not matter much trouble to you. :-)

OK, I guess it doesn't matter much...

> Please see above. Now it is non-conditional, so no problem here. 

OK.

> If the patch is okay, can I check it into a11y-branch?

Sure!

BTW if you prefer we can review the patches all at once when you merge
the branch into the mainline, instead of having to go through approval
for each of them.  But if you prefer us to review them as you write
them, we are also happy to do that.

Thanks!

Bye,
-- Ettore