Re: [evolution-patches] spell prefs in evo/mail

[Jeffrey Stedfast <fejj ximian com>]

On Tue, 2003-06-24 at 11:13, Radek Doulík wrote:
> attached patch adds default spell error color to schema file and moves
> spell preferences from /GNOME/Spell to /apps/evolution/mail/composer
> (gconf location).

+
+       str_color = gconf_client_get_string (prefs->gconf,
"/apps/evolution/mail/composer/spell_error_color", NULL);
+       gdk_color_parse (str_color, &prefs->spell_error_color);
+
+        val = gconf_client_get_without_default (prefs->gconf,
"/apps/evolution/mail/composer/spell_language", NULL); \

remove that trailing \ from the line. 

+        if (val) {
+               prefs->language_str = g_strdup (gconf_value_get_string
(val));
+               gconf_value_free (val);
+       } else
                prefs->language_str = g_strdup (def_lang);


[snip]

+               gchar *str_color = g_strdup_printf ("#%02x%02x%02x",
+                                                  
prefs->spell_error_color.red >> 8,
+                                                  
prefs->spell_error_color.green >> 8,
+                                                  
prefs->spell_error_color.blue >> 8);

mask those values with 0xff

[snip]

        fprintf (rc, "style \"evolution-mail-custom-fonts\" {\n");
        fprintf (rc, "        GtkHTML::spell_error_color =
\"#%02x%02x%02x\"\n",
-                red >> 8, green >> 8, blue >> 8);
+                spell_error_color.red >> 8, spell_error_color.green >>
8, spell_error_color.blue >> 8);

same here...


I think it looks good other than the few comments I had about it.

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com