Re: [evolution-patches] the patch to fix the bug caused by "bonobo_property_bag_client_set_value_gboolean" on solaris

[jack <jack jia sun com>]

hello JP!
          Thanks  for your suggestion!
          Could you commit the patch? and i have not the "check in" 
permission  
If you gave me the "Check in" permission and i can commit the patch that 
you accepted by myself.

Thanks
jack

JP Rosevear wrote:

> On Wed, 2003-06-18 at 06:18, jack wrote:
>  
>
> > JP and Rodrigo!
> >
> >    Firstly, Thanks for your comments!
> >
> >    I use  the "-1"  in place of "TRUE" in the 
> > "bonobo_property_bag_client_set_value_gboolean", it can work on solaris 
> > & GNOME 2.0.x.
> >    
>
> Still possibly leads to memory corruption.  Please commit your patch.
>
> -JP
>  


Index: calendar/gui/e-itip-control.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-itip-control.c,v
retrieving revision 1.121
diff -u -r1.121 e-itip-control.c
--- calendar/gui/e-itip-control.c	30 May 2003 17:35:10 -0000	1.121
+++ calendar/gui/e-itip-control.c	6 Jun 2003 09:48:54 -0000
@@ -84,7 +84,7 @@
 	gchar *delegator_address;
 	gchar *delegator_name;
 	gchar *my_address;
-	gboolean view_only;
+	gint   view_only;
 
 	gboolean destroyed;
 };
@@ -356,7 +356,7 @@
 	priv->delegator_address = NULL;
 	priv->delegator_name = NULL;
 	priv->my_address = NULL;
-	priv->view_only = FALSE;
+	priv->view_only = 0;
 	
 	/* Html Widget */
 	priv->html = gtk_html_new ();
@@ -1728,7 +1728,7 @@
 }
 
 void
-e_itip_control_set_view_only (EItipControl *itip, gboolean view_only)
+e_itip_control_set_view_only (EItipControl *itip, gint view_only)
 {
 	EItipControlPrivate *priv;
 
@@ -1737,7 +1737,7 @@
 	priv->view_only = view_only;
 }
 
-gboolean
+gint
 e_itip_control_get_view_only (EItipControl *itip)
 {
 	EItipControlPrivate *priv;
Index: calendar/gui/itip-bonobo-control.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/itip-bonobo-control.c,v
retrieving revision 1.11
diff -u -r1.11 itip-bonobo-control.c
--- calendar/gui/itip-bonobo-control.c	5 Mar 2003 15:50:33 -0000	1.11
+++ calendar/gui/itip-bonobo-control.c	6 Jun 2003 09:48:54 -0000
@@ -199,7 +199,7 @@
 		BONOBO_ARG_SET_STRING (arg, e_itip_control_get_from_address (itip));
 		break;
 	case VIEW_ONLY_ARG_ID:
-		BONOBO_ARG_SET_BOOLEAN (arg, e_itip_control_get_view_only (itip));
+		BONOBO_ARG_SET_INT (arg, e_itip_control_get_view_only (itip));
 		break;
 	}
 }
@@ -218,7 +218,7 @@
 		e_itip_control_set_from_address (itip, BONOBO_ARG_GET_STRING (arg));
 		break;
 	case VIEW_ONLY_ARG_ID:
-		e_itip_control_set_view_only (itip, BONOBO_ARG_GET_BOOLEAN (arg));
+		e_itip_control_set_view_only (itip, BONOBO_ARG_GET_INT (arg));
 		break;
 	}
 }
@@ -240,7 +240,7 @@
 	prop_bag = bonobo_property_bag_new (get_prop, set_prop, itip);
 	bonobo_property_bag_add (prop_bag, "from_address", FROM_ADDRESS_ARG_ID, BONOBO_ARG_STRING, NULL,
 				 "from_address", 0 );
-	bonobo_property_bag_add (prop_bag, "view_only", VIEW_ONLY_ARG_ID, BONOBO_ARG_BOOLEAN, NULL,
+	bonobo_property_bag_add (prop_bag, "view_only", VIEW_ONLY_ARG_ID, BONOBO_ARG_INT, NULL,
 				 "view_only", 0 );
 
 	bonobo_control_set_properties (control, bonobo_object_corba_objref (BONOBO_OBJECT (prop_bag)), NULL);