Re: [evolution-patches] proposed fix for bug #40788

[Not Zed <notzed ximian com>]

Reading some user mail on evolution@, i had a bit of a brainwave on this
thing.

Since the pop protocol is delimited by end of line sequences, perhaps we
should just treat the line as an -ERR line, and the capa code will
safely ignore this, and away we go.

Because - as far as i can tell, we've never seen this case hit anywhere
else.  So long as its been tested with telnet, and its not just our io
layer doing silly buggers.

A trivial patch, in camel_pop3_engine_iterate(), move the default: case
to the same spot as the '-': case, and remove the default case code.  I
think anyway.

Doing this would make it easier for the user, since they wouldn't have
to tweak any setting.

Having said that, the setting itself should probably still be there, as
other servers get confused in other ways by the capa query.

 Z


On Sat, 2003-06-07 at 01:17, Jeffrey Stedfast wrote:
> new patch attached.
> 
> On Thu, 2003-06-05 at 19:40, Not Zed wrote:
> > On Fri, 2003-06-06 at 06:14, Jeffrey Stedfast wrote:
> > > As discussed with ettore/danw/christine/etc, attached is a patch that
> > > will allow users to work around their broken POP servers so that they
> > > can still fetch mail.
> > > 
> > > Jeff of 
> > 
> > Just a couple of points:
> > 
> > +       if (!camel_url_get_param (service->url, "disable_extensions"))
> > +               store->engine = camel_pop3_engine_new (tcp_stream,
> > CAMEL_POP3_ENGINE_ENABLE_EXTENSIONS);
> > +       else
> > +               store->engine = camel_pop3_engine_new (tcp_stream, 0);
> > 
> > I'd rather this was one call, and some logic to setup a flags variable
> > before it, incase we ever need to add more flags/etc (e.g. 'use uidl
> > even if the server doesn't say it can').
> > 
> > I'd also prefer the flag was DISABLE_EXTENSIONS, since thats what the
> > parameter is, and so that the default can always be '0' for flag
> > options.
> > 
> > And
> > 
> > +       { CAMEL_PROVIDER_CONF_CHECKBOX, "disable_extensions", NULL,
> > +         N_("Enable workarounds for buggy POP servers"), "0" },
> > 
> > text might need to be a bit more specific, since there are so many
> > different pop server bugs :)
> > 
> > 
> > 
> > 
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches