Re: [evolution-patches] proposed fix for bug #40788

[Not Zed <notzed ximian com>]

On Fri, 2003-06-06 at 06:14, Jeffrey Stedfast wrote:
> As discussed with ettore/danw/christine/etc, attached is a patch that
> will allow users to work around their broken POP servers so that they
> can still fetch mail.
> 
> Jeff

Just a couple of points:

+       if (!camel_url_get_param (service->url, "disable_extensions"))
+               store->engine = camel_pop3_engine_new (tcp_stream,
CAMEL_POP3_ENGINE_ENABLE_EXTENSIONS);
+       else
+               store->engine = camel_pop3_engine_new (tcp_stream, 0);

I'd rather this was one call, and some logic to setup a flags variable
before it, incase we ever need to add more flags/etc (e.g. 'use uidl
even if the server doesn't say it can').

I'd also prefer the flag was DISABLE_EXTENSIONS, since thats what the
parameter is, and so that the default can always be '0' for flag
options.

And

+       { CAMEL_PROVIDER_CONF_CHECKBOX, "disable_extensions", NULL,
+         N_("Enable workarounds for buggy POP servers"), "0" },

text might need to be a bit more specific, since there are so many
different pop server bugs :)