Re: Could we discuss the patch again on gal atk implementation? was:Re: [evolution-patches] Re: GAL status

[Mike Kestner <mkestner ximian com>]

<mk> comments inline.


--- gal/Makefile.am     28 Jul 2003 16:36:10 -0000      1.67
+++ gal/Makefile.am     29 Jul 2003 10:56:27 -0000
@@ -1,5 +1,5 @@
 nonui_subdirs = util
-ui_subdirs    = widgets e-table e-text menus shortcut-bar . a11y
+ui_subdirs    = widgets e-table e-text menus shortcut-bar a11y .

<mk>The "." is not needed if the current dir is to be built last.  You
can remove it.</mk>
 
 SUBDIRS = $(nonui_subdirs) $(ui_subdirs) 
 
@@ -16,4 +16,5 @@
                   e-text/libetext.la \
                   menus/libgalmenus.la \
                   shortcut-bar/libshortcut-bar.la \
+                  a11y/libgal-a11y-2.0.la              \

<mk>Why are you linking the a11y lib into libgal-2.0.so?</mk>

                   $(EXTRA_GNOME_LIBS)
Index: gal/a11y/Makefile.am
===================================================================
RCS file: /cvs/gnome/gal/gal/a11y/Makefile.am,v
retrieving revision 1.3
diff -u -r1.3 Makefile.am
--- gal/a11y/Makefile.am        3 May 2003 17:05:28 -0000       1.3
+++ gal/a11y/Makefile.am        29 Jul 2003 10:56:31 -0000
@@ -1,4 +1,4 @@
-SUBDIRS = e-table e-text
+SUBDIRS = e-table e-text 

<mk>Please try to avoid whitespace changes.</mk>
 
 INCLUDES =                                     \
        -I$(top_srcdir)                         \
@@ -7,28 +7,30 @@
        $(GNOME_BONOBO_CFLAGS)                  \
        $(GNOME_INCLUDEDIR)                     \
        $(ICONV_CFLAGS)                         \
-        -DG_LOG_DOMAIN=\"gal-a11y\"
+       -DGTK_DISABLE_DEPRECATED=1              \
+       -DGDK_DISABLE_DEPRECATED=1              \
+       -DG_DISABLE_DEPRECATED=1                \
+       -DGNOME_DISABLE_DEPRECATED=1            \
+       -DG_LOG_DOMAIN=\"gal-a11y\"
 
-module_LTLIBRARIES = libgal-a11y-2.0.la
 
-moduledir = $(libdir)/gtk-2.0/modules
+lib_LTLIBRARIES = libgal-a11y-2.0.la
 
 libgal_a11y_2_0_la_LDFLAGS =    \
-       -rpath $(moduledir) -module -avoid-version -no-undefined \
+       -avoid-version -no-undefined \
         @LDFLAGS@
 
 libgal_a11y_2_0_la_SOURCES =   \
-       gal-a11y-util.c         \
-       init.c
+       gal-a11y-util.c
 
 libgal_a11y_2_0includedir =
$(includedir)/gal-$(GAL_API_VERSION)/gal/a11y
 
 libgal_a11y_2_0include_HEADERS =               \
-       gal-a11y-util.h
+       gal-a11y-util.h                 \
+       gal-a11y-factory.h
 
 
 libgal_a11y_2_0_la_LIBADD =            \
-       e-table/libgal-a11y-etable.la   \
        e-text/libgal-a11y-etext.la     \
-       $(top_builddir)/gal/libgal-2.0.la       \
+       $(top_builddir)/gal/e-text/libetext.la  \
        $(EXTRA_GNOME_LIBS)

<mk>You really don't want to link the e-table a11y code?</mk>

--- /dev/null   2002-08-31 07:31:37.000000000 +0800
+++ gal/a11y/gal-a11y-factory.h 2003-07-29 16:34:30.000000000 +0800
@@ -0,0 +1,94 @@
+/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8
-*- */
+/* GAL A11Y
+ * gal-a11y-factory.h

<mk> Hopefully somebody who understands atk has reviewed this too?  I
don't really know enough about it to give an informed opinion on this
factory code.</mk>

-- 
Mike Kestner <mkestner ximian com>