Re: [evolution-patches] Please review my patch for bug #45908

[Jeffrey Stedfast <fejj ximian com>]

looks fine.

On Mon, 2003-07-28 at 10:19, Antonio Xu wrote:
> Hello All,
> Because Dan's patch has been checked into trunk, I think I don't need to 
> add any enhanced code in my patch, So I create a new patch for bug 
> 45908. Could you review my patch? This patch need to be checked into 
> both trunk and branch.
> 
> Thanks
> Anto
> Dan Winship wrote:
> 
> >On Fri, 2003-07-25 at 04:14, Antonio Xu wrote:
> >  
> >
> >>Hello Ettore Perazzoli
> >>Can I add compiling option in this patch such as "ifdef LIBGNOME2.2"? 
> >>I'm sure that will not break GNOME 2.0 build of evolution. This patch is 
> >>very important for us.
> >>    
> >>
> >
> >Which part is very important? The gdk_pixbuf_loader_close part is
> >uncontroversial. That can go in no problem.
> >
> >If you want the icon theming stuff, it probably makes more sense to just
> >pull up the changes I made on head, since that fixes both the composer
> >and the message display, and works for both gnome 2.0 and 2.2.
> >
> >-- Dan
> >_______________________________________________
> >Evolution-patches mailing list
> >Evolution-patches lists ximian com
> >http://lists.ximian.com/mailman/listinfo/evolution-patches
> >  
> >
> 
> 
> 
> ______________________________________________________________________
> Index: composer/e-msg-composer-attachment-bar.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/e-msg-composer-attachment-bar.c,v
> retrieving revision 1.71
> diff -u -r1.71 e-msg-composer-attachment-bar.c
> --- composer/e-msg-composer-attachment-bar.c	23 Jul 2003 16:45:13 -0000	1.71
> +++ composer/e-msg-composer-attachment-bar.c	28 Jul 2003 13:16:07 -0000
> @@ -268,7 +268,9 @@
>  			
>  			if (!error) {
>  				int ratio, width, height;
> -				
> +
> +				gdk_pixbuf_loader_close (loader, NULL);
> +
>  				/* Shrink pixbuf */
>  				pixbuf = gdk_pixbuf_loader_get_pixbuf (loader);
>  				width = gdk_pixbuf_get_width (pixbuf);
> Index: composer/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
> retrieving revision 1.558
> diff -u -r1.558 ChangeLog
> --- composer/ChangeLog	25 Jul 2003 22:09:02 -0000	1.558
> +++ composer/ChangeLog	28 Jul 2003 13:18:07 -0000
> @@ -1,3 +1,8 @@
> +2003-07-28  Antonio Xu <antonio xu sun com>
> +
> +	* e-msg-composer-attachment-bar.c  (update): add
> +	gdk_pixbuf_loader_close to close pix buffer loading.  [#45908]
> +
>  2003-07-25  Larry Ewing  <lewing ximian com>
>  
>  	* e-msg-composer.c (GNOME_GTKHTML_EDITOR_CONTROL_ID): require the
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com