Re: [evolution-patches] Please review my patch for bug #45908
- From: Dan Winship <danw ximian com>
- To: Antonio Xu <antonio xu sun com>
- Cc: Ettore Perazzoli <ettore ximian com>, Jeffrey Stedfast <fejj ximian com>, evolution-patches ximian com, Not Zed <notzed ximian com>, Glynn Foster <glynn foster sun com>
- Subject: Re: [evolution-patches] Please review my patch for bug #45908
- Date: Fri, 25 Jul 2003 12:31:21 -0400
On Fri, 2003-07-25 at 04:14, Antonio Xu wrote:
> Hello Ettore Perazzoli
> Can I add compiling option in this patch such as "ifdef LIBGNOME2.2"?
> I'm sure that will not break GNOME 2.0 build of evolution. This patch is
> very important for us.
Which part is very important? The gdk_pixbuf_loader_close part is
uncontroversial. That can go in no problem.
If you want the icon theming stuff, it probably makes more sense to just
pull up the changes I made on head, since that fixes both the composer
and the message display, and works for both gnome 2.0 and 2.2.
-- Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]