Re: [evolution-patches] Please review my patch for bug #45908

[Antonio Xu <antonio xu sun com>]

Dan Winship wrote:

> On Fri, 2003-07-25 at 04:14, Antonio Xu wrote:
>  
>
> > Hello Ettore Perazzoli
> > Can I add compiling option in this patch such as "ifdef LIBGNOME2.2"? 
> > I'm sure that will not break GNOME 2.0 build of evolution. This patch is 
> > very important for us.
> >    
>
> Which part is very important? The gdk_pixbuf_loader_close part is
> uncontroversial. That can go in no problem.
>
> If you want the icon theming stuff, it probably makes more sense to just
> pull up the changes I made on head, since that fixes both the composer
> and the message display, and works for both gnome 2.0 and 2.2.
>
> -- Dan
>  
I have seen your fix in CVS head, I think your fix is right,  So I think 
I don't need to commit the enhanced code to trunk. But there still have 
another issue, Could you commit your patch into 1.4 branch, because we 
are working on branch now, and your patch is very important for us, I 
hope I can see your patch in branch asap. By the way, I couldn't find 
where you define HAVE_LIBGNOMEUI_GNOME_ICON_LOOKUP_H. Could you show me 
how to set it?

Thanks
Anto