Re: [evolution-patches] Re: Seeking review for merging a11y patch to HEAD

[Bolian Yin <bolian yin sun com>]

Hi Ettore,

Thanks for the review.
Ok, I will change the indent style and use "fprintf (stderr, ...)" to output debug info as used in other evolution code.

Padraig O'Briain, who is the main author of gail (the accessibility lib for gtk+) is also help review the patch. And he gave many good comments.

-Bolian

Ettore Perazzoli wrote:

On Tue, 2003-07-22 at 03:24, Bolian Yin wrote:
  

Hi Ettore,

I need to update the patch for a11y directory under evolution.  Then
new version is attached. I think is cleaner and more complete than the
old one. Sorry for the re-send.
    

Hi Bolian,

thanks for the patch!

Could you make the coding style consistent with Evolution, i.e. 8-space
indentation and tab stops?

As for the actual reviewing of the patch, I am actually quite ignorant
of the A11Y stuff.  Could someone else on the team who knows about A11Y
please have a look?  (Radek?  Rodrigo?)

The debugging printf()s should probably also be removed before you
commit this stuff, or wrapped into a DEBUG macro or something.

-- Ettore
_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches