Re: [evolution-patches] Re: Seeking review for merging a11y patch to HEAD



On Tue, 2003-07-22 at 03:24, Bolian Yin wrote:
> Hi Ettore,
> 
> I need to update the patch for a11y directory under evolution.  Then
> new version is attached. I think is cleaner and more complete than the
> old one. Sorry for the re-send.

Hi Bolian,

thanks for the patch!

Could you make the coding style consistent with Evolution, i.e. 8-space
indentation and tab stops?

As for the actual reviewing of the patch, I am actually quite ignorant
of the A11Y stuff.  Could someone else on the team who knows about A11Y
please have a look?  (Radek?  Rodrigo?)

The debugging printf()s should probably also be removed before you
commit this stuff, or wrapped into a DEBUG macro or something.

-- Ettore



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]