Re: [evolution-patches] Patch for bug 41839 (v2) , please review

[Not Zed <notzed ximian com>]

ok this patch looks fine.

by "1.5" i mean, at the moment "head".  it can go in both places for
now, i'll hopefully have the new display code poked in soon.

On Mon, 2003-07-07 at 14:00, Yiming Cao wrote:
> Thanks a lot for your comments. Here attaches updated patch, with only
> minor changes to the previous one. I've attached the patch to bugzilla.
> 
> On Mon, 2003-07-07 at 10:45, Not Zed wrote:
> > Hmm, yeah i think this looks ok.  Although the used-twice
> > 'is_button_press' variable probably isn't needed.
> > 
> > Is this code intended for the 1.4.x series, or for 1.5?  In 1.5, all of
> > this code is being completely redone (or at least, restructured
> > heavily).
> 
> I think we're working for 1.4.x, but we hope the patch can go into
> trunk. I don't know where v1.5 is coming really.
> 
> > 
> > 
> > On Fri, 2003-07-04 at 15:43, Yiming Cao wrote:
> > > Hi,
> > > 
> > > This patch is for bug 41839, which makes attachment (and signature)
> > > accessable with keyboard. Implemented as Ettore suggested:
> > >   Attachment and signature buttons are focused when accessed by
> > > keyboard, while not by mouse press. Hope this is the best choice.
> > > 
> > > Another minor bug fixed: the "inline" button is made insensitive when
> > > attachment can't be viewed inline, which seems more consistent with the
> > > popup menu's behavior.