Re: [evolution-patches] [PATCH] IMAP preauth and subcommand connection.



On Tue, 2003-07-01 at 16:21, Anna wrote:
> Hmmm. There are some issues with this placement...let's discuss the 
> purely cosmetic ones first:

Thanks for looking.

>  it should be "Connection to Server".

OK.

> * Ideally, you should add accelerators to the labels, 

OK.

> * I don't understand why you put this on the "Receiving Options" tab, 
> and not the "Receiving Mail" tab .

I agree -- I originally wanted to put it there, but the 'Receiving Mail'
tab is actually shared between IMAP and other providers, while the
'Receiving Options' tab is private and simple to add things to.

To add it to the Receiving Mail tab, I'd need add a new option
'CAMEL_PROVIDER_SUPPORTS_CUSTOM_COMMAND' along the same lines as the
existing 'CAMEL_PROVIDER_SUPPORTS_SSL', and modify the GUI stuff in
mail/mail-account-gui.c accordingly.

It does make sense to do that -- other providers (POP, NNTP) could
feasibly use the same option in future. I would like an ack from
whomever would need to approve such a change before I bother though...

-- 
dwmw2




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]