[evolution-patches] gal crash fix for 46165 (evo 1.4 crasher)



changelog says it all.

Chris

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/ChangeLog,v
retrieving revision 1.800.2.11
diff -u -r1.800.2.11 ChangeLog
--- ChangeLog	1 Dec 2003 17:45:23 -0000	1.800.2.11
+++ ChangeLog	10 Dec 2003 18:45:35 -0000
@@ -1,3 +1,10 @@
+2003-12-10  Chris Toshok  <toshok ximian com>
+
+	* gal/e-text/e-text.c (e_text_command): it's possible to get to
+	this function without the EText ever being realized.  Since we
+	create the layout in realize(), let's just create it here too.
+	Fixes crash bug 46165 (aka "The Bug with a million dups").
+
 2003-11-30 Suresh Chandrasekharan  <suresh chandrasekharan sun com>
 
 	Bug Id #51527 "gal widgets produces backspace for Ctrl-space for 
Index: gal/e-text/e-text.c
===================================================================
RCS file: /cvs/gnome/gal/gal/e-text/e-text.c,v
retrieving revision 1.145.4.4
diff -u -r1.145.4.4 e-text.c
--- gal/e-text/e-text.c	6 Nov 2003 04:11:56 -0000	1.145.4.4
+++ gal/e-text/e-text.c	10 Dec 2003 18:45:37 -0000
@@ -3210,6 +3210,13 @@
 		break;
 	}
 
+	/* it's possible to get here without ever having been realized
+	   by our canvas (if the e-text started completely obscured.)
+	   so let's create our layout object if we don't already have
+	   one. */
+	if (!text->layout)
+		create_layout (text);
+
 	if (scroll && !text->button_down) {
 		/* XXX do we really need the @trailing logic here?  if
 		   we don't we can scrap the loop and just use


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]