Re: [evolution-patches] Fix for Bug #51482



On Pre , 2003-12-05 at 17:27, Jeffrey Stedfast wrote:
> +                     "weight", bold || unread ? PANGO_WEIGHT_BOLD :
> PANGO_WEIGHT_NORMAL,
> 
> you don't need the || unread since 'bold' already covers that.

Ah. Ok.

> +                     "foreground_set", unread ? TRUE : FALSE
> 
> you don't need this bit since we aren't setting the foreground colour
> anymore

Ah. True.

> you also need a ChangeLog :-)

Yeah. I avoid making ChangeLog entries in patches so they don't end up
conflicting when I cvs up before committing because someone else put a
change in. :)

> other than that, looks good.

Committed with your suggested changes.

-- dobey

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]