On Enj , 2003-12-04 at 18:57, Not Zed wrote: > This only partially fixes it. > > 1. the shell view doesn't operate like this in 1.5, so you're making > it work like it used to (good) In my testing, I am making both displays of the mail be consistent. The shell view does operate like this in 1.5. Perhaps not what it is coded to do, and not what you expect from the code, but this is what the UI does. Perhaps ETree is just selecting the last un-hidden message in a direction if you try to select past the bounds in that direction, or something similar, but that is what is happening. > 2. it doesn't close, if its the last message displayed (last message > in the folder). There is no reliable way to tell whether a message is the last or first one in the folder. Closing the window would be inconsistent with the behaviour in the shell view. Also, the Next/Previous toolbar buttons are not getting their sensitivity changed when the message is the first or last in the list. Which, I guess, is a separate bug, but similar enough to mention here. > I was wrong about the set_message thing, that just sets the cursor on > the messagelist which then propagates through etable into displaying a > message. > > It might need some more code/another virtula method to set the > message, e.g. set_message_uid and set_message, in a similar way > set_folder_uri and set_folder work (although the former needs to go > through messaelist still, and wouldn't change). I can add that api if > you want (5 minutes work). I'm not sure that will help if you want the window to close if the message is on either bounds of the folder. Since the MessageList depends heavily on ETree, and we don't set flags on the message to specify if it is the first or last message in a folder. I don't think a set_message_uid would help me either, since the list of uids doesn't seem to change, even after the message_list_select () call, when doing message_list_get_selected (). -- dobey > On Fri, 2003-12-05 at 10:08, Rodney Dawes wrote: > > This patch fixes bug #51082 by switching direction if > > message_list_select () returns FALSE. It makes the > > message browser and folder view essentially behave in > > the same manner for deleting messages. > > > > -- dobey
Attachment:
signature.asc
Description: This is a digitally signed message part