Re: [evolution-patches] Updated Patch for Bug 46351
- From: Rodrigo Moya <rodrigo ximian com>
- To: Carl sun <carl sun sun com>
- Cc: York Du <yuedong du sun com>, SCERI EVOLUTION ACC <sceri-evolution-acc sun com>, EVOLUTION PATCH <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] Updated Patch for Bug 46351
- Date: Fri, 05 Dec 2003 16:58:18 +0100
On Fri, 2003-12-05 at 04:46, Carl sun wrote:
> Hi, York
>
> Attached is the reduced and updated patch for Bug 46351 (the
> original version will modify nearly 100 LOCs, while this new version
> only affects 20 LOCs ).
> Thank you for your earnest review on it and much help to me,
> which improves the quality of the patch !
>
@@ -92,6 +94,9 @@
parent_class = g_type_class_peek_parent (class);
+ GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class) ;
+ widget_class->mnemonic_activate =
e_timezone_entry_mnemonic_activate;
+
this is C99, declaring a variable after other code.
Apart from that, it looks ok to me, although I'm not sure it might
affect other code, but I suppose not.
cheers
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]