Re: [evolution-patches] patch for 47541

[Dan Winship <danw ximian com>]

On Thu, 2003-08-28 at 09:21, Jeffrey Stedfast wrote:
> That's not the url that evo-mail gets when it passes the url off to
> gnome_url_show() is all I know. At least not on my box.
Dude, try it! Click me. (Or just right click -> Copy Link Location and compare that with what you see in the message source.)

The problem is that if you follow the directions she gave, you end up with:
>     <a href="" href="http://www.ximian.com">www.ximian.com">
in the message, which is wrong, because it's missing the protocol, so it's a relative URL, and evolution apparently considers the base URL of the message to start with "cid:/", so you get "cid:/www.ximian.com". (FWIW, according to RFC 2557, it should actually be "thismessage:/www.ximian.com".)

So:

1. Cynthia, you should be entering "http://www.ximian.com" rather than just "www.ximian.com" for the link target.
2. The composer Insert Link dialog should prepend "http://" for the user if they enter a URL with no protocol
3. The mailer probably shouldn't call gnome_url_show on cid: URLs (or thismessage: URLs or anything else that refers only to something within the message and not out in the real world.)

-- Dan

> Jeff
>
> On Thu, 2003-08-28 at 05:40, Cynthia Gu wrote:
> > I do the following to see the bug:
> > 
> > 1. Compose a new mail and set the format to HTML
> > 2. Insert a link, for example www.ximian.com and send the mail to yourself
> > 3. Receive the mail and click on the link to open.
> > now, the browser is open but nothing display.
> > type the command:
> > ps -ef |grep moz
> > you can see the following command:
> > 
> > /usr/lib/mozilla-1.4/mozilla-bin -UILocale en-US cid:/www.ximian.com
> > 
> > That is to say, the url evolution send out is not correct.
> > 
> > Can the description above be reproduced on your side?
> > 
> > Cynthia
> > 
> > 
> > 
> > Jeffrey Stedfast wrote:
> > 
> > >I just tried to reproduce your bug, and the url didn't even start with a
> > >cid: anyway, so I have no idea what you are trying to fix but it surely
> > >is not the bug # you referenced.
> > >
> > >Jeff
> > >
> > >On Wed, 2003-08-27 at 07:24, Cynthia Gu wrote:
> > >  
> > >
> > >>Hi, 
> > >>
> > >>Attached patch for 47541.
> > >>        
> > >>This is a patch for solving the problem of "Hyperlink cannot be 
> > >>opened in mozilla browser" . Pl. check this and let me know.
> > >>        
> > >>Thanks & Regards,
> > >>Cynthia
> > >>    
> > >>