Re: [evolution-patches] Seeking review for bug #47751 & #47752

[Jeffrey Stedfast <fejj ximian com>]

looks ok to me

On Wed, 2003-08-20 at 11:02 -0400, Not Zed wrote:
> Hi guys,
> 
> I did some investigation of keybindings in gtkdialog - it already hooks
> up the escape key.  Only - it only activates if you have a
> GTK_RESPONSE_CANCEL in the dialog buttons(!).  We only have a
> GTK_RESPONSE_REJECT, even though we actually have a GTK_STOCK_CANCEL
> button ....
> 
> So all we need to do is change it to use GTK_RESPONSE_CANCEL and the
> escape binding will happen automagically, and also be rebindable 'for
> free' as well.  This already happens for the top-level filter editor
> window and probably others.
> 
> The attached patch does some of the work, but more is required in
> mail/*, and possibly in the addressbook (anywhere where the filtereditor
> stuff is used).
> 
>  Michael
> 
> On Wed, 2003-08-20 at 05:19, Maxx Cao wrote:
> > Hi Jeff,
> > 
> > Thanks a lot for your rapid comments! 
> > 
> > As you suggested, I've changed the warning message to
> > 
> >     "You are about to cancel editing this rule. Are you sure you want
> > to cancel?"
> > 
> > I think it's clear enough and not too long. Users can understand what
> > canceling 
> > means, don't they?
> > 
> > I've attached the new patch here. Please review, thanks.
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com