[evolution-patches] [Fwd: Re: [Evolution] timezone in the header of a reply quote]

From: David Woodhouse <dwmw2 infradead org>
To: evolution-patches ximian com
Subject: [evolution-patches] [Fwd: Re: [Evolution] timezone in the header of a reply quote]
Date: Fri, 15 Aug 2003 12:41:12 +0100

Alternative (and preferred) patch to the previous one... we don't just
quote the Date: header intact; we reformat it. But we do retain the
timezone from the original mail, which is surely the right thing to
do...

-- 
dwmw2

--- Begin Message ---

From: David Woodhouse <dwmw2 infradead org>
To: Martin List-Petersen <martin list-petersen se>
Cc: Andreas =?ISO-8859-1?Q?W=FCst?= <awuest swissonline ch>, Evolution Mailinglist <evolution lists ximian com>
In-Reply-To: <1060941439 26545 58 camel loke>
References: <1060885784 23771 5 camel loke>
	 <1060886868 10490 9 camel tazmanian-devil boston ximian com>
	 <1060888767 23788 12 camel loke>
	 <1060889218 19345 2 camel tazmanian-devil boston ximian com>
	 <1060889124 23771 15 camel loke>  <1060938780 744 10 camel andrewII>
	 <1060941439 26545 58 camel loke>
Message-Id: <1060947369 32490 6 camel hades cambridge redhat com>
Mime-Version: 1.0
Sender: evolution-admin lists ximian com
Errors-To: evolution-admin lists ximian com
Precedence: bulk
Date: Fri, 15 Aug 2003 12:36:09 +0100
Subject: Re: [Evolution] timezone in the header of a reply quote
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Fri, 2003-08-15 at 09:55 +0200, Martin List-Petersen wrote:
> It is that direction, that i thought in, especially some people not
> might want to have the timezone info.

If anyone expresses a preference to omit timezone info, please do us all
a favour by taking them out back and shooting them. A time in any form
without unambiguous (preferably numeric) timezone info is completely
pointless.

> On Fri, 2003-08-15 at 02:18, Not Zed wrote:
> > You are talking about the timezone IN the message you're replying to? 

No, he's not -- since Evolution (brokenly IMHO) converts the time to the
replier's localtime in attributions. Patch to fix this below (I much
prefer this over the trivial one I just sent to just include the local
timezone after the bogus conversion).

I _think_ it's OK just to use gmtime and add the offset with %%+05d. Not
enough coffee yet this morning, er, afternoon...

--- mail/mail-callbacks.c~	Wed Jul  9 17:18:29 2003
+++ mail/mail-callbacks.c	Fri Aug 15 12:26:57 2003
@@ -995,6 +995,7 @@
 	GConfClient *gconf;
 	EIterator *iter;
 	time_t date;
+	int date_ofs;
 	char *url;
 	
 	gconf = mail_config_get_gconf_client ();
@@ -1189,9 +1190,13 @@
 			name = _("an unknown sender");
 		}
 		
-		date = camel_mime_message_get_date (message, NULL);
-		e_utf8_strftime (format, sizeof (format), _("On %a, %Y-%m-%d at %H:%M, %%s wrote:"), localtime (&date));
-		text = mail_tool_quote_message (message, format, name && *name ? name : address);
+		date = camel_mime_message_get_date (message, &date_ofs);
+		/* Convert to UTC */
+		date -= (date_ofs / 100) * 60;
+		date -= date_ofs % 100;
+
+		e_utf8_strftime (format, sizeof (format), _("On %a, %Y-%m-%d at %H:%M %%+05d, %%s wrote:"), gmtime (&date));
+		text = mail_tool_quote_message (message, format, date_ofs, name && *name ? name : address);
 		mail_ignore (composer, name, address);
 		if (text) {
 			e_msg_composer_set_body_text (composer, text);


-- 
dwmw2

_______________________________________________
evolution maillist  -  evolution lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution

--- End Message ---

Follow-Ups:
- Re: [evolution-patches] [Fwd: Re: [Evolution] timezone in the header of a reply quote]
  - From: David Woodhouse

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]