[evolution-patches] Re: [Evolution] timezone in the header of a reply quote

[David Woodhouse <dwmw2 infradead org>]

On Thu, 2003-08-14 at 19:29 +0100, Martin List-Petersen wrote:
> Hi,
> 
> i would like to know, if there is a way to include the timezone in the
> reply quote header like i've seen it at Apple Mail. Something like:
> "On Thursday, Aug 14, 2003, at 02:14 Europe/Stockholm, Martin
> List-Petersen wrote:"

Evolution's current behaviour is misleading, and certainly needs
modifying somehow. 

It currently 'translates' the Date: header of the original mail to the
replier's localtime in the attribution, which I think is the wrong thing
to do -- in this case, for example, it's not true to say that you wrote
_anything_ at "19:29 +0100" since you actually wrote it at "20:29:44
+0200". They may be equivalent but they're not identical -- we _are_
losing information when we convert.

It's made far worse because we currently omit any form of timezone
information from the attribution. I think it would be much better to
quote the Date: header precisely as it was in the mail to which we're
replying.

Alternatively, the patch below at least adds the timezone offset of the
zone we've converted to in the attribution, so we're not being quite so
confusing...

Index: mail/mail-callbacks.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-callbacks.c,v
retrieving revision 1.450
diff -u -p -r1.450 mail-callbacks.c
--- mail/mail-callbacks.c	23 Jul 2003 15:01:26 -0000	1.450
+++ mail/mail-callbacks.c	15 Aug 2003 11:05:36 -0000
@@ -1190,7 +1190,7 @@ mail_generate_reply (CamelFolder *folder
 		}
 		
 		date = camel_mime_message_get_date (message, NULL);
-		e_utf8_strftime (format, sizeof (format), _("On %a, %Y-%m-%d at %H:%M, %%s wrote:"), localtime (&date));
+		e_utf8_strftime (format, sizeof (format), _("On %a, %Y-%m-%d at %H:%M %z, %%s wrote:"), localtime (&date));
 		text = mail_tool_quote_message (message, format, name && *name ? name : address);
 		mail_ignore (composer, name, address);
 		if (text) {



-- 
dwmw2