[evolution-patches] Please review my patch for bug #47349
- From: Antonio Xu <antonio xu sun com>
- To: evolution-patches <evolution-patches lists ximian com>
- Cc: gtkhtml-maintainers ximian com
- Subject: [evolution-patches] Please review my patch for bug #47349
- Date: Mon, 11 Aug 2003 12:27:14 +0800
Hello All,
Could you review my patch for bug #47349?
If you use the difference input method in composer,GtkIMContext's
commit signal may interrupt another singal handler's process sometimes
and cause some crash issues. When user write some characters with the
difference input method, Some of characters maybe invisible, but if you
click mouse button, those characters must be
showing immediately.But sometimes,the handler process of button press
may be interrupted by GtkIMContext's commit singal, and commit handler's
process will insert that text object. that will release the object which
has been getten in the handler process of button press. In my patch, I
add gtk_html_im_reset before html_engine_get_object_at, that can resolve
the crash problem of evolution.
Thanks
Antonio Xu
Index: src/htmlengine-edit-movement.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlengine-edit-movement.c,v
retrieving revision 1.15
diff -u -r1.15 htmlengine-edit-movement.c
--- src/htmlengine-edit-movement.c 25 Apr 2001 21:31:53 -0000 1.15
+++ src/htmlengine-edit-movement.c 8 Aug 2003 07:29:19 -0000
@@ -137,6 +137,8 @@
g_return_if_fail (e != NULL);
g_return_if_fail (HTML_IS_ENGINE (e));
+ gtk_html_im_reset (e->widget);
+
obj = html_engine_get_object_at (e, x, y, &offset, TRUE);
if (obj == NULL)
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]