[evolution-patches] Please review my patch for bug #45911



Hello All,
	Could you review my patch for bug #45911?
This bug only happen on SuSe 8.2, If you use difference input method in composer,GtkIMContext's commit signal may interrupt another singal handler's process sometimes and cause some crash issues. When user write some characters with the difference input method, Some of characters maybe invisible, but if you click mouse button, those characters must be showing immediately.But sometimes,the handler process of button press may be interrupted by GtkIMContext's commit singal, and commit handler's process will recreate a new cursor for html engine. In my patch, I copy original cursor to revert current cursor of html engine rather than create a new cursor. That can resolve the crash issue of evolution on SuSe 8.2.
   	

Thanks
Antonio Xu




Index: src/htmlengine-edit-cut-and-paste.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlengine-edit-cut-and-paste.c,v
retrieving revision 1.93
diff -u -r1.93 htmlengine-edit-cut-and-paste.c
--- src/htmlengine-edit-cut-and-paste.c	20 May 2003 18:25:14 -0000	1.93
+++ src/htmlengine-edit-cut-and-paste.c	8 Aug 2003 07:42:33 -0000
@@ -876,8 +876,7 @@
 	printf ("position after merge %d\n", e->cursor->position);
 #endif
 
-	html_cursor_destroy (e->cursor);
-	e->cursor = html_cursor_dup (orig);
+	html_cursor_copy (e->cursor, orig);
 	html_cursor_jump_to_position_no_spell (e->cursor, e, position_after);
 
 	if (check)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]