Re: [evolution-patches] composer: forward inline with inlined images fix

[Radek Doulík <rodo ximian com>]

On Tue, 2003-04-22 at 10:48, Not Zed wrote:
> On Tue, 2003-04-22 at 15:50, Radek Doulík wrote:
> > On Tue, 2003-04-22 at 04:36, Not Zed wrote:
> > > Is there any particular bug this is addressing?
> > 
> > no, I noticed it while fixing other bug in gtkhtml (drafts with inlined
> > images were not showing the images)
> > 
> > > Doesn't this actually change the structure of the forwarded message?
> > 
> > Yes it does. It makes images from the original message residing in
> > multipart/related to be related in the new message as well. Before they
> > were added as attachments so as part of multipart/mixed. Do you think
> > it's wrong?
> 
> Well i'm not sure.
> 
> Hrmm.  What if you dont have 'sent html mail' turned on?  Will it send a
> multipart like:
> 
> multipart/related
>   text/plain
>   image/png
>   image/png
> 
> for example, which isn't really correct since text/plain can't reference
> other parts.

It sends just text/plain without inlined images in that case. The
message is not multipart and has content type text/plain.

> so yeah i'm not sure, it looks correct, it should probably go in, just
> wondering if there are other issues with it

yeah, thanks for your comments. I hope it's OK to commit so I committed
the patch with ChangeLog entries to CVS.