Re: [Evolution-hackers] [PATCH evolution-data-server] imapx: Remove check for NIL separator

[Matthew Barnes <mbarnes redhat com>]

On Mon, 2013-12-30 at 00:37 +0100, Lubomir Rintel wrote:
> This has been tested with MUNI IMAP server along with:
> Subject: [PATCH evolution-data-server] imapx: Treat BODY[HEADER] as equivalent to RFC822.HEADER
> Date: Sun, 29 Dec 2013 21:10:57 +0100
> Message-id: <1388347857-1479-1-git-send-email-lkundrak v3 sk>
>
>  camel/providers/imapx/camel-imapx-namespace.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/camel/providers/imapx/camel-imapx-namespace.c b/camel/providers/imapx/camel-imapx-namespace.c
> index c86165b..c924d39 100644
> --- a/camel/providers/imapx/camel-imapx-namespace.c
> +++ b/camel/providers/imapx/camel-imapx-namespace.c
> @@ -93,7 +93,6 @@ camel_imapx_namespace_new (CamelIMAPXNamespaceCategory category,
>       CamelIMAPXNamespace *namespace;
>  
>       g_return_val_if_fail (prefix != NULL, NULL);
> -     g_return_val_if_fail (separator != '\0', NULL);
>  
>       /* Not bothering with GObject properties for this class. */
>  

Thanks for that.  I remember not being sure about that assertion when I
wrote it.  Either the RFC wasn't clear or I missed some fine print.

I'll commit this and your BODY[HEADER] patch for the next release.

For future reference it's better to submit patches to our bug tracking
system [1] so we can... well, track them easier.

Matthew Barnes


[1] http://bugzilla.gnome.org