Re: [Evolution-hackers] Some minor Camel API breaks

On Mon, 2012-08-13 at 08:19 -0400, Matthew Barnes wrote:
> * camel_session_get_service() is now camel_session_ref_service() and
>   returns a new reference to a CamelService.  The caller must call
>   g_object_unref() on it.

This is all great work! Just a point to note: Telepathy uses the
convention of calling refcounting getters ‘_dup_’ (e.g.
“camel_session_dup_service()”) rather than ‘_ref_’. This seems better
(imo) because ‘ref’ could get confused with a reference-count-increasing
function which _doesn’t_ return the reference. If it’s not too late,
perhaps Camel could be changed to use this ‘_dup_’ convention instead?

Then again, ATK uses the ‘_ref_’ convention, so there seems to be no
consistent standard anyway.


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]