Re: [Evolution-hackers] (summarize ][) New 'eclient' branch in eds
- From: Milan Crha <mcrha redhat com>
- To: evolution-hackers gnome org
- Subject: Re: [Evolution-hackers] (summarize ][) New 'eclient' branch in eds
- Date: Tue, 10 May 2011 07:12:13 +0200
On Mon, 2011-05-09 at 12:04 -0400, Matthew Barnes wrote:
> On Mon, 2011-05-09 at 17:49 +0200, Milan Crha wrote:
> > It's just because of (so called) consistency. With merging common error
> > codes into E_CLIENT_ERROR_ "namespace" I realized that checking for
> > particular errors will not be that easy as is now, because one might
> > have two switches, one for domain E_CLIENT_ERROR and the other for
> > E_CAL/BOOK_ERROR. Not a big deal, but still.
>
> If you're using a switch statement to check for specific GErrors then
> you're doing it wrong. You should be using g_error_matches() for each
> case, so it doesn't matter if all the error codes are in the same domain
> or they're all in different domains.
>
> I'd like to get rid of the redundancy.
OK, done on both server and client sides. Those common properties has
macro prefix "CLIENT_", those specific are prefixed with "BOOK_"/"CAL_".
Milan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]