Re: [Evolution-hackers] Heads Up: More Camel API breakage in 2.31



On Sun, 2010-07-11 at 09:05 -0400, Matthew Barnes wrote:
> Instead I saw this cute stunt in quite a few
> places:
> 
>     CamelException ex;
> 
>     camel_exception_init (&ex);
>     do_something_that_can_fail (folder, message, &ex);
>     camel_exception_clear (&ex); 

Hey, at least you didn't see this:

 imapx_server_fetch_new_messages (is, is->select_pending, TRUE, TRUE,
				  /* FIXME */ camel_exception_new());

Now you've committed the GError conversion, I can commit a sane version
of that. Thanks :)

-- 
dwmw2



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]