Re: [Evolution-hackers] Code reorganization (was: kill-bonobo with -no-undefined)
- From: Milan Crha <mcrha redhat com>
- To: evolution-hackers gnome org
- Subject: Re: [Evolution-hackers] Code reorganization (was: kill-bonobo with -no-undefined)
- Date: Mon, 11 May 2009 12:25:31 +0200
On Sun, 2009-05-10 at 16:39 -0400, Matthew Barnes wrote:
> I need to take a closer look at the details here, but I can comment on a
> few things right away. Overall I really like this. Great work!
> On Thu, 2009-05-07 at 13:25 +0200, Milan Crha wrote:
> > Changes in folder structure:
> > /widgets/text -> /widgets/misc
> This is the only part I'm not too keen on. Why was this necessary? I'd
> prefer to keep the ancient GAL leftovers cleanly separated from our more
> modern widgets, if possible.
EText requires ECanvas, EReflow requires ECanvas and EText and some
other parts from misc. This was the first thing I changed. But it seems
that moving e-reflow to 'text' directory might work too.
> > /a11y/addressbook -> /addressbook/gui/widgets/a11y
> > /a11y/calendar -> /calendar/gui/a11y
> > /a11y/e-table -> /widgets/table/a11y
> > /a11y/e-text -> /widgets/misc/a11y
> > /a11y/widgets -> /widgets/misc/a11y
> Yes. Huge +1. Thank you!
> > Some e-table related files from /widgets/misc had been moved
> > to /widgets/table.
> Nice. You might also scavenge e-util for any old ETable or EText
> utilities we're not using elsewhere and move them under /widgets/table
> or /widgets/text, just so they're safely tucked away and out of sight.
> Just from quickly scanning the files there I see several potential
Hmm, it didn't yell to me anything when compiling.
> > New library libemformat.la which contains necessary minimum to be shared
> > between mail and composer:
> > /emformat
> > em-format.h
> > em-format.c
> > em-format-quote.h
> > em-format-quote.c
> > em-stripsig-filter.h
> > em-stripsig-filter.c
> > Makefile.am (attached)
> Wow, I'm impressed you actually got that to work! To clarify, this is
> so the composer can call em_utils_part_to_html() (or whatever we rename
> it) without linking to the mailer. That right?
> Instead of a new library, why don't we just stick it in e-util?
I do not know, I thought it's still too tight to mailer. But yes, can be
moved also there.
> illegal dependency I see is "mail-config.h", but that's just to grab a
> GConf key. Easy to work around. (Maybe you fixed that already? I
> haven't looked.)
Yes, that was necessary to remove, and really easy.
> Suggest we drop the 'm' (for mail) in 'em' and just call it EFormat,
Yup, I agree.
] [Thread Prev