Re: [Evolution-hackers] PATCH: gtkhtml-search.c fixes segfault in gtk_html_isearch

[Matthew Barnes <mbarnes redhat com>]

On Wed, 2008-10-15 at 12:03 +0100, Andrew S. Townley wrote: 
> I was trying to figure out how searching worked with GtkHTML, and I
> discovered the following minor bug.  Calling gtk_html_isearch() assumed
> that the editor component had already been set.  If it wasn't, you got a
> segfault.

Thanks for the patch, Andrew.  I'll get that committed.  You might keep
an eye out for similar cases in other parts of the code.


> Now, I haven't actually found anywhere that the editor API *is* set, so
> pointers to an example would also be appreciated. :)

The editor API is set by users of the GtkHTML object to customize its
behavior.  The stock editor that ships with GtkHTML has an example.
Look in:

   gtkhtml/components/editor/gtkhtml-editor.c:editor_init()


To partially answer your previous mail, we _do_ hope to eventually
migrate to WebKit within the next year, since GtkHTML is effectively
unmaintained these days.  I've worked on the editor component and
dabbled at some pieces of the core HTML renderer, but most of the core
developers with a deep understanding of the renderer have long since
moved on.  And with a large PIM application to maintain with our limited
manpower, you can imagine why we're looking to get out of the HTML
rendering business.

I don't think anyone on the team has begun looking in detail at the
technical issues involved in migrating to WebKit yet, particularly with
respect to HTML editing (to my knowledge, we're still waiting on
WebKit's GObject-based editing API).  So I don't have an answer to your
"link_clicked" question yet except to say that Alp Toker seems pretty
receptive to our editing needs and I expect to be able to negotiate a
solution with him when the time comes (if it's still an issue by then).

As for adding CSS support, I believe it was indeed roughed in but
unfinished by the former GtkHTML developers.  For Evolution it simply
hasn't been a priority.  Contributions are always welcome, but with
GtkHTML's days numbered (as far as the Evolution team is concerned), I
would caution you to consider whether starting such a large project is
worth the effort.

Hope this helps,
Matthew Barnes