Re: [Evolution-hackers] Memory leak in camel-imap-message-cache.c

[Srinivasa Ragavan <sragavan novell com>]

Look at the free_part function being called at 
g_hash_table_foreach (cache->parts, free_part, cache);

It frees the key.

-Srini.

On Mon, 2008-01-14 at 02:58 +0100, Philip Van Hoof wrote:
> Hi there,
> 
> The cache->parts = g_hash_table_new (g_str_hash, g_str_equal); of
> camel-imap-message-cache.c does not free its keys (it's the default way
> of creating a hashtable, so there's no freeup function provided for the
> keys).
> 
> Yet at (or around) line 118 we see this:
> 
> g_hash_table_insert (cache->parts, g_strdup (uid), subparts);
> 
> That uid is string-copied. So either the hashtable needs a freeup
> function or the string should not be copied or .. this is wrong.
> 
> Because I don't know how important the string copying is, what do you
> guys think we should do here?
> 
>