Re: [Evolution-hackers] Largefile support

[Jeffrey Stedfast <fejj novell com>]

I meant to keep it with the same defaults as before... did I goof? :(

The only 'gotcha' I can think of by enabling it by default is that it
might break ABI if old builds were 32bit off_t's (the new off_t's would
be 64bit).

I think the best coarse of action is to default it to the same off_t
size as before (which, even if the old behavior was to enable largefile,
since it was broken, might not have setup 64bit off_t's).

Jeff

On Mon, 2008-04-07 at 12:40 -0400, Matthew Barnes wrote:
> On Mon, 2008-04-07 at 17:11 +0100, fejj svn gnome org wrote:
> > Author: fejj
> > Date: Mon Apr  7 17:11:40 2008
> > New Revision: 8625
> > URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=8625&view=rev
> > 
> > Log:
> > 2008-04-07  Jeffrey Stedfast  <fejj novell com>
> > 
> > 	* configure.in: Do proper checks for largefile support and
> > 	properly setup proper CFLAGS to support it.
> > 
> 
> Hey Jeff,
> 
> Just curious why you chose to disable this by default.  Seems like we'd
> want to take advantage of largefile support if it's available, or are
> there undesirable tradeoffs involved?
> 
> Matthew Barnes
>