[Evolution-hackers] XML APIs in evolution

[Gilles Dartiguelongue <dartigug esiee fr>]

Hi list,

while walking through the tree to create bug #437579 [1] patches, I've
found that quite a bunch of warnings (most of them in fact) where
relating to calls to libxml functions without casting.

Typical situation is that you have a string "toto" and want to get the
property of that node. You'll do xmlGetProp (mynode, "toto"); and paf,
you got a warning because this functions wants a xmlChar * which is a
unsigned char * and that by default, strings are char *. In this
particular case, gcc is not smart enough to find out that this is what
we want and that's perfectly fine.

On the other hand, there are some xml functions from evolution in
e-utils/e-xml-utils.[ch]. Guess what, they have the same problem !

I've done all the casting patchs and I think this is the right thing to
do ATM. It will cleanup compilation output and allow to focus on other
warnings but I feel it doesn't help with code reading.

There are some places where e-xml-utils functions are mixed with libxml
calls. Don't remember exactly the place though.

The question is, what shall we do now ?
-- 
Gilles Dartiguelongue <dartigug esiee fr>