Re: [Evolution-hackers] [Evolution] ANNOUNCE: Evolution 2.10.0, Evolution-Data-Server 1.10.0, GtkHTML 3.14.0 and Evolution Exchange 2.10.0



On Wed, 2007-03-14 at 12:44 +0530, Harish Krishnaswamy wrote:
> On Tue, 2007-03-13 at 23:04 -0400, Claudio Saavedra wrote:
> > El Tue, 13-03-2007 a las 13:08 +0530, Harish Krishnaswamy escribió:
> > > Hi All,
> > > 
> > > The Evolution Team is pleased to announce the release of
> > > 
> > >                 * Evolution 2.10.0
> > > 
> > >                 * Evolution-Data-Server 1.10.0
> > 
> > I'm sorry to spoil the fun, but you guys left
> > 
> >  g_print ("\n\a Header string finally is ********** \n%s\n",
> >            header_spec->str);
> > 
> > in e-d-s, camel/providers/imap/camel-imap-folder.c:2367, which is pretty
> > annoying, specially because of the '\a' (i.e., a beep every time a new
> > mail arrives or a mail is moved to another folder).
> > 
> > This appeared with a patch for this bug[1], I tried to warn but it seems
> > it got unnoticed. Hope it's not too late to fix this.
> > 
> > Claudio
> > 
> > [1] http://bugzilla.gnome.org/show_bug.cgi?id=400841
> > 
> 
> You are right - this *is* an annoyance and should have been pruned
> before the release,
> but it is a tad late - the tarballs are already out.
> 
> I also feel that this g_print statement should be conditional on the
> debug flags turned on - and should not add noise to normal usage. The
> use of \a looks superfluous too.
> 
> Varadhan/Sankar : Can you wrap the statement within a suitable DEBUG
> level check and get the change committed asap.  TIA.

I have committed a change by which the debug statement is made
conditional.
http://svn.gnome.org/viewcvs/evolution-data-server?view=rev&revision=7654

With the released version, you will get a beep sound only when Evolution
is launched from a terminal and there are new mails in a folder. IMHO,
that is not so critical that we need to make a dot-release for this
patch alone. 

> Thanks,
> Harish
> 
> 
-- 
Sankar




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]