Re: [Evolution-hackers] ANNOUNCE: Evolution 2.10.0, Evolution-Data-Server 1.10.0, GtkHTML 3.14.0 and Evolution Exchange 2.10.0

[Harish Krishnaswamy <kharish novell com>]

On Tue, 2007-03-13 at 23:04 -0400, Claudio Saavedra wrote:
> El Tue, 13-03-2007 a las 13:08 +0530, Harish Krishnaswamy escribió:
> > Hi All,
> > 
> > The Evolution Team is pleased to announce the release of
> > 
> >                 * Evolution 2.10.0
> > 
> >                 * Evolution-Data-Server 1.10.0
> 
> I'm sorry to spoil the fun, but you guys left
> 
>  g_print ("\n\a Header string finally is ********** \n%s\n",
>            header_spec->str);
> 
> in e-d-s, camel/providers/imap/camel-imap-folder.c:2367, which is pretty
> annoying, specially because of the '\a' (i.e., a beep every time a new
> mail arrives or a mail is moved to another folder).
> 
> This appeared with a patch for this bug[1], I tried to warn but it seems
> it got unnoticed. Hope it's not too late to fix this.
> 
> Claudio
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=400841
> 

You are right - this *is* an annoyance and should have been pruned
before the release,
but it is a tad late - the tarballs are already out.

I also feel that this g_print statement should be conditional on the
debug flags turned on - and should not add noise to normal usage. The
use of \a looks superfluous too.

Varadhan/Sankar : Can you wrap the statement within a suitable DEBUG
level check and get the change committed asap.  TIA.

Thanks,
Harish


-- 
Novell, Inc. 
Software for the Open Enterprise™
http://www.novell.com