Re: [Evolution-hackers] Quick 'n dirty POP summary support

About this one and FYI:

On Wed, 2007-01-10 at 20:46 +0100, Philip Van Hoof wrote:
> @@ -386,6 +433,11 @@
>                 if (pop3_store->cache && fi->uid)
>                         camel_data_cache_remove(pop3_store->cache, "cache", fi->uid, NULL);
>                 }
> +
> +
> +               /* TNY TODO Shouldn't this remove message from memory? Oh well, adding it */
> +               camel_object_unref (CAMEL_OBJECT (message)); 

I think this is a memory leak in the existing implementation of
camel_pop3_delete_old ("message" is never unreferenced, yet created).

If it is a memory leak, and it looks like it is, then this is actually a
huge one. No? (entire messages are leaked, or at least streams to files
being cached, keeping files open and stuff like that).

Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]