[Evolution-hackers] Streamlining e-text.c & e-cell-text.c



Hi,

I was looking at Evolution's code, when I saw that
insert_preedit_text() in e-text.c (widgets/text/e-text.c) and
layout_with_preedit in e-cell-text.c (widgets/table/e-cell-text.c) so
almost the same thing : fetch the preedit string, add it to the
current cursor location & update the layout.

But they both do the same thing, but do it differently. Was this on
some purpose or that the implementations gradually changed over a
period of time?

IMHO, they can be programmed in the same way (though their in/out
params can be what they are). This will aid bugfixing.

Open to comments...

Makuchaku
http://makuchaku.info



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]