Re: [Evolution-hackers] Marcus Bains Line in calendar



On Thu, 2005-03-31 at 12:22 -0500, Thouis (Ray) Jones wrote:
> On Mon, 28 Mar 2005 22:45:26 +0100, JP Rosevear <jpr novell com> wrote:
> > So I've been playing around with this since last week, very cool.  We
> > could definitely take this feature for 2.3/2.4.  Some comments:
> > 
> > -the configuration item should probably be at the bottom of the General
> > section just so it doesn't needlessly disrupt the relative layout of the
> > other items
> > -shouldn't hard code the colors of the line - maybe the ACTIVE color or
> > something
> > -shouldn't use localtime to determine the time, should use
> > icaltime_current_time_with_zone and pass in the configured timezone and
> > then convert that to a time_t.
> > -the exact time doesn't seem to be shown as in the above link
> 
> 
> I've made changes to address all of these comments, except two:
> 
> Showing exact time on the line
>    This would complicate the code (not much, but some), and I think it
> makes things more cluttered, visually, without providing a lot of
> extra information.  If I need to know the exact time, I can glance at
> the clock.  Usually, all I need to know is the approximate time, which
> the Marcus Bains line shows pretty well.

One thing that would be nice about showing the exact time is it clearly
indicates the meaning of the line for people who have never seen it
before.  I wondered what it was when I first saw it in the screenshots.

Nat





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]