Re: [Evolution-hackers] Bug 200821: We need a Notes component. - first implementation



I have attached the gal-related changes required for your patch to build
with Evoution HEAD. It works fine after that - I have also started using
the memos component :-).

Also, please make the necessary changes for the code to align to code style
guidelines (C++ style comments etc. to be removed).

Harish



On Thu, 2005-07-14 at 07:11 -0700, Nathan Owens wrote:
Hey,

I've actually been updating my code with respect to CVS. Right now, the
attachments still work for me (with it being updated to the latest from CVS),
but I'll contact srag to see how it might need to change.

I've actually uploaded the latest patches against CVS to the sourceforge.net
project (http://sourceforge.net/projects/evolution-memos/). I'll attach the
patches to the bugzilla bug later today during my lunch break (since I'm at
work).

I'm glad you like it! :)

Thanks,
Nathan

--- Harish <kharish novell com> wrote:

> Hi,
> 
> sorry for not responding earlier. Had been tied down with the 2.3.5
> deadlines.
> I will do a follow-up on the status of your copyright submission and get
> back to 
> you in a couple of days.
> 
> Regarding the patch, it is really awesome :-).
> However, since gal has moved into evolution now and the attachment
> handling
> has (and is) undergoing changes, it cannot be readily applied on to the
> HEAD.
> 
> I am trying out the patch - so I will update the patch with the
> necessary changes
> for gal and send it out later in the day. You may want to talk to 
> srag (sragavan novell com) on reworking the attachment part.
> 
> Thanks for the great work,
> Harish
> 
> On Mon, 2005-07-11 at 19:44 -0700, Nathan Owens wrote: 
> 
> > (I've been moving so it took me a while to respond)
> > 
> > I sent in the copyright assignment form 2 weeks ago, yet my name hasn't
> shown
> > up on the Evolution copyright page. I've e-mailed copyright ximian com, but
> I
> > get a "user unknown" error from the mail server. Any idea who I should
> contact?
> > 
> > --- Not Zed <notzed ximian com> wrote:
> > 
> > > 
> > > OOh rather cool (well it looks cool anyway :).
> > > 
> > > It would've been nice if it used a gtktreeview instead of an etable -
> > > apart from trying not to expand etable use in evolution, it might've
> > > shown how tasks could've also been moved away from it as well.  But that
> > > isn't a trivial task, and gtktreeview doesn't do everything etree does
> > > either.
> > 
> > I looked at gtktreeview, and it looks like it'd be good to at least try for
> a
> > future version - I like what the UI looks like, but haven't looked at what
> it'd
> > take to use a gtktreeview (or etree). What does etree provide that
> gtktreeview
> > doesn't have?
> > 
> > > I just had a quick scan of the patches, they look mostly ok to me, only
> > > obvious things to me are tiny things like c99/c++ style comments which
> > > we try to avoid and not sorting filenames in the makefiles.
> > 
> > I think I've taken care of that in the evolution-memos CVS project on
> > sourceforge.net (and I'll put some patches up soon on project site).
> > 
> > > Can someone more appropriate than a mail hacker give some positive
> > > feedback on this quite significant bit of work?
> > 
> > Yes, please! I haven't heard any other response except from Not Zed. Would
> I
> > get more response from evolution-patches? (I don't think that's an
> appropriate
> > place to discuss a major new feature, though.)
> > 
> > > I presume that the common code between tasks + notes + calendar has been
> > > separated out and re-used where possible still?
> > 
> > I've tried to re-use as much as possible. There are no doubt places that
> I've
> > overlooked and will merge in with time.
> > 
> > > I would be inclined to put it in - well with those minor niggles
> > > addressed, and some ChangeLog entries, copyright assignment paperwork
> > > etc.  And then work on bugs coming up to the 2.4 release, but it is a
> > > question for the calendar maintainers who would now have a significant
> > > bit of extra code to worry about (its easy to say yes when it isn't your
> > > problem).
> > 
> > They might have to do some maintenence, but I'm definitely willing to work
> on
> > it from here on out if they're willing to accept my patches.
> > 
> > I'd like to know what the calendar maintainers think about my
> implementation.
> > What needs to be worked on before it can get added to Evolution?
> > 
> > Thanks,
> > Nathan Owens
> > 
> > 
> > 
> > >  Michael
> > > 
> > > On Thu, 2005-06-23 at 08:51 -0700, Nathan Owens wrote:
> > > > This feature request has been open since October, 2000. Back in
> December,
> > > 2003,
> > > > I sent a few e-mails to this list to try to figure out the best way to
> > > create
> > > > the component. Until recently, I haven't had the time to work on it.
> Now
> > > that
> > > > I've had time, I've tried to make sure I use the suggestions from those
> > > > e-mails, though a lot has changed since then.
> > > > 
> > > > I've created a sourceforge project at
> > > > http://sourceforge.net/projects/evolution-memos (I'm calling it Memos,
> not
> > > > Notes, since I use a PalmOS PDA and that's what it calls it). There are
> > > patches
> > > > on there for the gnome-2-8-branch of CVS, evolution 2.3.3.1/eds
> 1.3.3.1,
> > > and
> > > > also CVS from earlier this week. The CVS repository for the project
> > > contains
> > > > the source tree for both evolution and the evolution-data-server from a
> few
> > > > days ago (I'll keep updating it as well). See the bug page
> > > > (http://bugzilla.gnome.org/show_bug.cgi?id=200821) for some other info
> > > (patches
> > > > are there, as well).
> > > > 
> > > > Screenshots are located at:
> > > >
> > >
> >
>
http://evolution-memos.sourceforge.net/pics/Screenshot-Evolution%20-%20Memos.png
> > > >   (grouping by categories)
> > > > 
> > > >
> > >
> >
>
http://evolution-memos.sourceforge.net/pics/Screenshot-Journal%20entry%20-%20Random%20entry%20of%20text.png
> > > >   (editing/creating a new memo)
> > > > 
> > > > Here's how I designed it:
> > > > - based on the Tasks component (originally cut-and-paste, but now quite
> > > >   different) - this means it's in the libevolution-calendar.so library.
> > > > - uses VJOURNAL (suggested in a December 2003 e-mail)
> > > > - works similarly to the Memos program on a PalmOS PDA.
> > > > - Memo content is stored in the Description field of an e-cal object
> > > > - Summary is generated from Memo content, since we don't want the
> summary
> > > to
> > > >   differ with the first part of the memo content.
> > > > - gnome-pilot conduit works - it uses the description/memo content for
> the
> > > >   'struct memo->text' entity from pilot-link that's used to sync with
> Memos
> > > > - the gnome-pilot conduit uses the old MemoDB, instead of the newer
> > > >   MemosDB-PMe.pdb - this limits the text given to the PDA (or retrieved
> > > from
> > > > it)
> > > >   to 4KB.
> > > >   - The conduit CAN work with the new Memos database file (I've done it
> on
> > > >     mine), but not everyone has the new DB. Until a way is found to
> detect
> > > > which
> > > >     database to use, I'd like to stick to using the old DB.
> > > >   - Memos in Evolution are NOT limited to the 4KB, though. This would
> just
> > > be
> > > >     stupid.
> > > > 
> > > > 
> > > > I think that's all I have about the component. I'd like to get comments
> on
> > > the
> > > > layout, code, design, etc. I'd like to see this component eventually
> get
> > > into
> > > > the Evolution source tree so that people can start using it. It's been
> > > > requested a whole lot, and every few months, we'll see another post
> about
> > > "it's
> > > > not here yet?!" on the bug page (as well as duplicate bugs). People
> want
> > > it,
> > > > and after having used it for a little over a week myself, I'd say it's
> a
> > > > greatly-needed component.
> > > > 
> > > > Hope you guys like the initial component.
> > > > 
> > > > Thanks,
> > > > Nathan Owens
> > > > 
> > > > 
> > > > 		
> > > > ____________________________________________________ 
> > > > Yahoo! Sports 
> > > > Rekindle the Rivalries. Sign up for Fantasy Football 
> > > > http://football.fantasysports.yahoo.com
> > > > _______________________________________________
> > > > evolution-hackers maillist  -  evolution-hackers lists ximian com
> > > > http://lists.ximian.com/mailman/listinfo/evolution-hackers
> 
=== message truncated ===



		
____________________________________________________
Start your day with Yahoo! - make it your home page 
http://www.yahoo.com/r/hs 
_______________________________________________ evolution-hackers maillist - evolution-hackers lists ximian com http://lists.ximian.com/mailman/listinfo/evolution-hackers
--
Harish Krishnaswamy <kharish novell com>
--- ../e-memos.c	2005-07-19 10:13:42.000000000 +0530
+++ e-memos.c	2005-07-19 10:11:54.000000000 +0530
@@ -29,11 +29,6 @@
 
 #include <gnome.h>
 #include <libgnomevfs/gnome-vfs-ops.h>
-#include <gal/e-table/e-table-scrolled.h>
-#include <gal/menus/gal-view-instance.h>
-#include <gal/menus/gal-view-factory-etable.h>
-#include <gal/menus/gal-view-etable.h>
-
 #include "e-util/e-error.h"
 #include "e-util/e-categories-config.h"
 #include "e-util/e-config-listener.h"
@@ -42,7 +37,12 @@
 #include <libecal/e-cal-time-util.h>
 #include <libedataserver/e-url.h>
 #include <libedataserver/e-categories.h>
+
 #include "widgets/menus/gal-view-menus.h"
+#include "widgets/table/e-table-scrolled.h"
+#include "widgets/menus/gal-view-instance.h"
+#include "widgets/menus/gal-view-factory-etable.h"
+#include "widgets/menus/gal-view-etable.h"
 #include "dialogs/delete-error.h"
 #include "e-calendar-marshal.h"
 #include "calendar-config.h"
--- ../e-memo-table.h	2005-07-19 10:14:05.000000000 +0530
+++ e-memo-table.h	2005-07-19 10:12:03.000000000 +0530
@@ -26,7 +26,7 @@
 #define _E_MEMO_TABLE_H_
 
 #include <gtk/gtktable.h>
-#include <gal/e-table/e-table-scrolled.h>
+#include <widgets/table/e-table-scrolled.h>
 #include <widgets/misc/e-cell-date-edit.h>
 #include "e-activity-handler.h"
 #include "e-cal-model.h"
--- ../e-memo-table.c	2005-07-19 10:14:18.000000000 +0530
+++ e-memo-table.c	2005-07-19 10:12:17.000000000 +0530
@@ -35,11 +35,11 @@
 #include <sys/stat.h>
 #include <unistd.h>
 #include <gnome.h>
-#include <gal/widgets/e-gui-utils.h>
-#include <gal/e-table/e-cell-checkbox.h>
-#include <gal/e-table/e-cell-toggle.h>
-#include <gal/e-table/e-cell-text.h>
-#include <gal/e-table/e-cell-combo.h>
+#include <widgets/misc/e-gui-utils.h>
+#include <widgets/table/e-cell-checkbox.h>
+#include <widgets/table/e-cell-toggle.h>
+#include <widgets/table/e-cell-text.h>
+#include <widgets/table/e-cell-combo.h>
 #include <e-util/e-dialog-utils.h>
 #include <widgets/misc/e-cell-date-edit.h>
 #include <widgets/misc/e-cell-percent.h>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]