Re: [Evolution-hackers] [PATCH] Compile fix in addressbook-view.c

On Wed, 2005-08-03 at 13:21 +0200, Jules Colding wrote:
> On Wed, 2005-08-03 at 19:03 +0800, Not Zed wrote:
> > A smaller patch would probaby be to define a forward reference to the
> > function somewhere near the top of the file.
> Sure, is that the generally preferred fix for these kind of problems?
> Should I commit the attached patch?

To be honest, it depends on my mood!  I dont like having everything
forward referenced because it is more work if anything changes (there is
a lot of object-based code which does this and its a pita to
maintain) ... but in general, the smaller the diff the better too; it
helps track changes easier using cvs annotate for example.

Yeah this last looks good, go for it.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]