Re: [Evolution-hackers] [PATCH] Compile fix in addressbook-view.c

[Jules Colding <colding omesc com>]

On Wed, 2005-08-03 at 19:03 +0800, Not Zed wrote:
> A smaller patch would probaby be to define a forward reference to the
> function somewhere near the top of the file.

Sure, is that the generally preferred fix for these kind of problems?
Should I commit the attached patch?

Regards,
  jules


Index: addressbook/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1971
diff -u -p -r1.1971 ChangeLog
--- addressbook/ChangeLog	3 Aug 2005 08:34:01 -0000	1.1971
+++ addressbook/ChangeLog	3 Aug 2005 11:19:57 -0000
@@ -1,3 +1,8 @@
+2005-08-03  Jules Colding  <colding omesc com>
+
+	* gui/component/addressbook-view.c: Added forward references to functions that were
+	used before being defined.
+
 2005-03-03  Sushma Rai  <rsushma novell com>
 
 	* gui/widgets/eab-gui-util.c (eab_transfer_contacts): Initialize the
Index: addressbook/gui/component/addressbook-view.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/component/addressbook-view.c,v
retrieving revision 1.37
diff -u -p -r1.37 addressbook-view.c
--- addressbook/gui/component/addressbook-view.c	3 Aug 2005 08:23:26 -0000	1.37
+++ addressbook/gui/component/addressbook-view.c	3 Aug 2005 11:19:57 -0000
@@ -121,6 +121,9 @@ static void addressbook_view_init	(Addre
 static void addressbook_view_class_init	(AddressbookViewClass *klass);
 static void addressbook_view_dispose    (GObject *object);
 
+static ESource *find_first_source  (ESourceList *source_list);
+static ESource *get_primary_source (AddressbookView *view);
+
 typedef struct {
 	GtkWidget *editor;
 	char *uid;