Re: [Evolution-hackers] New Menu Layout

[Not Zed <notzed ximian com>]

Hmm, this seems to be a pretty big patch.  It would probably be easier if you just stuck to the ui parts in the patch, and not a major re-factor of bits of code (admitedly needed refactoring).

Which parts were crashing?

Issues:
 - Folder->Mark Messages As Read does nothing, i presume this was the old 'mark all messages as read' one, and it doesn't read the same anymore
 - folder->subscriptions makes no sense, it isn't a folder operation.  if everything else that was in tools is now in edit, why not move it there?
 - message->mark as ... doesn't make sense much either.  1. it is hard ot get to, and 2. they alter the message state, i.e. edit it, they don't alter the messages themselves, which are immutable.
 - similalry message->goto doesn't make much sense, since you're altering the view.  These two ops are pretty likely some of the most often accessed ones, it seems odd to change them, they were quite fine where they were I thought.
 - a bunch of plugins mess up the menu, there is now a blank menu past help for a few items that used to be in actions (save attachments and mailing list actions plugins).
 - the actions menu in the other components now shows up after help (maybe this only happens if you start in the mailer).
 - its a vfolder not a search folder
 - 'tools' seems to be a bit redundant, everything that was in it is now in tools, except for some arbitrary choices which aren't.
 - what happened to cut and paste?!?
 - folder->expunge seems to be in a weird spot.  there are other menu items which appear to be in strange locations (add sender to addressbook, 'go to', mark as, 
 - edit select all text/deselect all text aren't hooked up.  what does deselect all text do, sounds uncommon.

Anyway, take most of those comments with a grain of salt (like i'm sure you will), although i find no paste a bit of a killer (this is how i normally move mails around for example, and i'm sure i'm not alone).  Tools looks like it has to die though.


On Wed, 2005-04-20 at 16:26 -0400, Rodney Dawes wrote:
> So,
>
> Here is the initial working patch to change the layout for menus in the
> Mailer. The plan is to do this work incrementally, and the Mailer is the
> largest component in terms of menus, and number of users, so it was done
> first. It is not 100% complete, but this patch does have >= 90% of the
> changes necessary for it. Some of the changes are not implemented in
> this patch, as they were casuing other components to crash. Most
> notable, the "Custom View" and "Search" menus, were causing other
> componets to crash, as they access them as well, with generic paths.
>
> I want to get this patch in CVS as soon as possible, preferrably before
> the first release of 2.3, so that we can get a lot of testing during the
> 2.3 cycle. So, once this patch is approved and I commit it to CVS, I
> will start working to get the rest of the components up to par as well,
> and will take feedback about these menus and work to improve them still.
>
> -- dobey