Re: [Evolution-hackers] Bug #127546 Gaim Evolution presence integration.

I have to be honest and say, I really don't like these patches, and
that's not because you're using my bounty entry to write them ;)
You're doing way more than you should, and in a way that will make
Evo's presence integration look and work differently from other
upcoming desktop apps.

You duplicate a framework that Galago already provides, and you're
doing your own widgets and rendering when Galago provides those as
well. Your patch is 260KB currently, while mine (which does the same
stuff) is 10KB. I don't think it needs to be so complicated,
especially when the framework is already provided.

Part of what you would get with the widgets are standard icons. Your
current method will show the AIM icon for every protocol, it seems.
That's confusing to users when they're looking at MSN contacts. Also,
some of the Galago stuff you think is broken actually isn't, I just
don't think you're using the API correctly. You shouldn't be touching
galago_core_set_watch_all(). That's more of a backend thing.

Is there still need for a dependency on Gaim (which will cause
Evolution to break more often than not, since we're not guaranteeing
any API stability at the moment) when you're working on Galago


On Wed, 29 Sep 2004 11:23:25 -0400, praveen kandikuppa
<praveen9 gmail com> wrote:
> I have posted an updated patch for this bug at
> Please have a look
> at the README file in the attachment. The main new feature is now
> galago ( can be used as one of the
> backends for querying presence information and in my opinion it would
> be better to have it as default, it is im client independent and has
> instantaneous updates on signoff/signon etc.
> PObject is used now while displaying presence icons in mail display.
> there are various code cleanups and less hacks and it should be a lot
> more readable now. the README file describes some more changes.
> In my opinion the patch implements most of the bug and sans some minor
> changes should be ready. Whom do i contact/mail to get the changes
> reviewed/accepted. I cannot see any owner associated The patch is
> little big to be mailed to evolution-patches. Can i mail a bzip2 file
> to the patches list?.
> Praveen.
> _______________________________________________
> evolution-hackers maillist  -  evolution-hackers lists ximian com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]