[Evolution-hackers] Re: connector and API changes [was Re: [evolution-patches] folder info->path removal patch]

[Not Zed <notzed ximian com>]

On Tue, 2004-05-25 at 10:58 -0400, Dan Winship wrote:
> On Tue, 2004-05-25 at 11:13 +0000, Not Zed wrote:
> > I got bored with fixing crappy little bugs today so I took on the
> > removal of the now redundant 'path' from CamelFolderInfo.
> > 
> > Ahh yeah, so this was a bit more involved than I thought it would be.
> > But I think I managed to get all cases - not really sure so sending
> > this patch out for comment.
>
> You missed camel-exchange-store.c...
>
> Now that Connector is in GNOME CVS (evolution-exchange module), people
> making API changes in evo/eds should feel free to update things there as
> well. And by "feel free", I mean "feel guilty if they don't". :-)

Hah, i didn't want to dirty myself :)

Here's the diff, which i'll probably have committed by the time you read this, if i go ahead with the other commit.

That function is evil, it could leak memory and it doesn't parse the url properly.  You really gotta stop allocating stuff in one place and freeing it in another, it creates lots of hard to track down bugs :P

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
retrieving revision 1.30
diff -u -3 -r1.30 ChangeLog
--- ChangeLog	25 May 2004 13:19:12 -0000	1.30
+++ ChangeLog	26 May 2004 04:02:51 -0000
@@ -1,3 +1,8 @@
+2004-05-26  Not Zed  <NotZed Ximian com>
+
+	* camel/camel-exchange-store.c (make_folder_info): fixed for camel
+	api change, removed path.
+
 2004-05-25  Nicel KM  <mnicel novell com>
 
 	* calendar/e-cal-backend-exchange.c (get_object_list):
Index: camel/camel-exchange-store.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/camel/camel-exchange-store.c,v
retrieving revision 1.2
diff -u -3 -r1.2 camel-exchange-store.c
--- camel/camel-exchange-store.c	21 May 2004 18:42:08 -0000	1.2
+++ camel/camel-exchange-store.c	26 May 2004 04:02:52 -0000
@@ -325,8 +325,7 @@
 	info = g_new0 (CamelFolderInfo, 1);
 	info->name = name;
 	info->uri = uri;
-	info->path = g_strdup (path);
-	info->full_name = g_strdup (info->path + 1);
+	info->full_name = g_strdup (path + 1);
 	info->unread = unread_count;
 
 	if (flags & CAMEL_STUB_FOLDER_NOSELECT)