Re: [Evolution-hackers] compile bug ..

["Todd T. Fries" <evolution email fries net>]

You are correct.

e-contact-list-editor.c: In function `select_names_ok_cb':
e-contact-list-editor.c:670: syntax error before `corba_control'
e-contact-list-editor.c:674: `control_widget' undeclared (first use in
this function)
e-contact-list-editor.c:674: (Each undeclared identifier is reported
only once
e-contact-list-editor.c:674: for each function it appears in.)
e-contact-list-editor.c: In function `setup_corba':
e-contact-list-editor.c:704: warning: implicit declaration of function
`GNOME_Evolution_Addressbook_SelectNames_addSection'
e-contact-list-editor.c: In function `select_cb':
e-contact-list-editor.c:726: warning: implicit declaration of function
`GNOME_Evolution_Addressbook_SelectNames_activateDialog'
e-contact-list-editor.c: In function `extract_info':
e-contact-list-editor.c:987: warning: passing arg 1 of
`e_destination_export_to_vcard_attribute' discards qualifiers from
pointer target type
e-contact-list-editor.c: At top level:
e-contact-list-editor.c:472: warning: `list_deleted_cb' defined but not
used
gmake[1]: *** [e-contact-list-editor.lo] Error 1
gmake[1]: Leaving directory `/wd0i/obj/ports/evolution-1.5.90/evolution-
1.5.90/addressbook/gui/contact-list-editor'
gmake: *** [all] Error 2

With your simpler diff, however, things compile as well for me.  While
OpenBSD does have gcc3 available, do not expect it to be the default for
i386 quite some time, perhaps sooner, but don't count on it.

On Mon, 2004-07-12 at 22:50 -0700, Lonnie Borntreger wrote:
> On Tue, 2004-07-13 at 11:09 +0800, Not Zed wrote:
> > 
> > what is the failure you get?
> 
> With gcc 2.95, my guess is that it doesn't like variable definition to
> occur after logic/assignment (i.e. the ce= line).  An easier fix would
> be to change:
> 
> EContactListEditor *ce;
> 
> ce = E_CONTACT_LIST_EDITOR (data);
> 
> to:
> 
> EContactListEditor *ce = E_CONTACT_LIST_EDITOR (data);
> 
> Even though it has an assignment, it is during the variable definition,
> so that's OK.
> 
> Lonnie Borntreger
> 
> 
> > On Mon, 2004-07-12 at 16:06 -0500, Todd T. Fries wrote: 
> > > I don't know what compile flags or compilers you guys are using to compile
> > > current cvs, or even 1.5.90, but this change broke my ability to build
> > > evolution on OpenBSD.
> > > 
> > > blue$ gcc -v
> > > Reading specs from /usr/lib/gcc-lib/i386-unknown-openbsd3.5/2.95.3/specs
> > > gcc version 2.95.3 20010125 (prerelease, propolice)
> > > blue$
> > > 
> > > Here's the diff to fix.. quite trivial:
> > > 
> > > Index: e-contact-list-editor.c
> > > ===================================================================
> > > RCS file: /cvs/gnome/evolution/addressbook/gui/contact-list-editor/e-contact-list-editor.c,v
> > > retrieving revision 1.60
> > > diff -u -r1.60 e-contact-list-editor.c
> > > --- e-contact-list-editor.c	2 Jul 2004 18:32:18 -0000	1.60
> > > +++ e-contact-list-editor.c	12 Jul 2004 16:16:59 -0000
> > > @@ -666,11 +666,14 @@
> > >  
> > >  	EContactListEditor *ce;
> > >  
> > > +	GtkWidget *control_widget;
> > > +	Bonobo_Control corba_control;
> > > +
> > >  	ce = E_CONTACT_LIST_EDITOR (data);
> > >  
> > > -	Bonobo_Control corba_control = GNOME_Evolution_Addressbook_SelectNames_getEntryBySection
> > > +	corba_control = GNOME_Evolution_Addressbook_SelectNames_getEntryBySection
> > >  			(ce->corba_select_names, "Members", ev);
> > > -	GtkWidget *control_widget = bonobo_widget_new_control_from_objref (corba_control, CORBA_OBJECT_NIL);
> > > +	control_widget = bonobo_widget_new_control_from_objref (corba_control, CORBA_OBJECT_NIL);
> > >  
> > >  	bonobo_widget_get_property (BONOBO_WIDGET (control_widget), "destinations",
> > >  					    TC_CORBA_string, &string, NULL);
> > -- 
> > 
> > Michael Zucchi <notzed ximian com>
> > 
> > Novell's Evolution and Free
> > Software Developer
> 
> _______________________________________________
> evolution-hackers maillist  -  evolution-hackers lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-hackers
-- 
Todd Fries .. todd fries net

 _____________________________________________
|                                             \  1.636.410.0632 (voice)
| Free Daemon Consulting, LLC                 \  1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com             \  1.866.792.3418 (FAX)
| "..in support of free software solutions."  \  1.700.227.9094 (IAXTEL)
|                                             \          250797 (FWD)
 \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
                                                 
              37E7 D3EB 74D0 8D66 A68D  B866 0326 204E 3F42 004A
                        http://todd.fries.net/pgp.txt