Re: [Evolution-hackers] compile bug ..

[Lonnie Borntreger <email borntreger com>]

On Tue, 2004-07-13 at 11:09 +0800, Not Zed wrote:
> 
> what is the failure you get?

With gcc 2.95, my guess is that it doesn't like variable definition to
occur after logic/assignment (i.e. the ce= line).  An easier fix would
be to change:

EContactListEditor *ce;

ce = E_CONTACT_LIST_EDITOR (data);

to:

EContactListEditor *ce = E_CONTACT_LIST_EDITOR (data);

Even though it has an assignment, it is during the variable definition,
so that's OK.

Lonnie Borntreger


> On Mon, 2004-07-12 at 16:06 -0500, Todd T. Fries wrote: 
> > I don't know what compile flags or compilers you guys are using to compile
> > current cvs, or even 1.5.90, but this change broke my ability to build
> > evolution on OpenBSD.
> > 
> > blue$ gcc -v
> > Reading specs from /usr/lib/gcc-lib/i386-unknown-openbsd3.5/2.95.3/specs
> > gcc version 2.95.3 20010125 (prerelease, propolice)
> > blue$
> > 
> > Here's the diff to fix.. quite trivial:
> > 
> > Index: e-contact-list-editor.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/addressbook/gui/contact-list-editor/e-contact-list-editor.c,v
> > retrieving revision 1.60
> > diff -u -r1.60 e-contact-list-editor.c
> > --- e-contact-list-editor.c	2 Jul 2004 18:32:18 -0000	1.60
> > +++ e-contact-list-editor.c	12 Jul 2004 16:16:59 -0000
> > @@ -666,11 +666,14 @@
> >  
> >  	EContactListEditor *ce;
> >  
> > +	GtkWidget *control_widget;
> > +	Bonobo_Control corba_control;
> > +
> >  	ce = E_CONTACT_LIST_EDITOR (data);
> >  
> > -	Bonobo_Control corba_control = GNOME_Evolution_Addressbook_SelectNames_getEntryBySection
> > +	corba_control = GNOME_Evolution_Addressbook_SelectNames_getEntryBySection
> >  			(ce->corba_select_names, "Members", ev);
> > -	GtkWidget *control_widget = bonobo_widget_new_control_from_objref (corba_control, CORBA_OBJECT_NIL);
> > +	control_widget = bonobo_widget_new_control_from_objref (corba_control, CORBA_OBJECT_NIL);
> >  
> >  	bonobo_widget_get_property (BONOBO_WIDGET (control_widget), "destinations",
> >  					    TC_CORBA_string, &string, NULL);
> -- 
> 
> Michael Zucchi <notzed ximian com>
> 
> Novell's Evolution and Free
> Software Developer