Re: [Evolution-hackers] Patch for image scale down

[Not Zed <notzed ximian com>]

On Wed, 2003-10-08 at 01:24, Frederic Crozat wrote:
> The attached patch make evolution uses 
> gnome_thumbnail_scale_down_pixbuf instead of gdk_pixbuf_scale_simplified
> if it is available (ie on GNOME platform >= 2.2), which fixes big
> performance problem when it tries to scale down big images (see bug 
> http://qa.mandrakesoft.com/show_bug.cgi?id=6065 ). It also seems mini
> pixbuf is re-computed when switching from open to close for inline
> attachement (I didn't fix this problem).
Hmm, they should be cached, in 1.4 anyway, head doesn't from memory.

> This is a known problem in gdk_pixbuf_scale (which can be workarounded
> by using gdk_pixbuf_loader_set_size, only with GTK+ 2.2).
If you need gtk+ 2.2 for it, shouldn't it just use that directly?  And what happens if you use that on pre 2.2 versions, i.e. does it have a detrimental affect, or is it just effectively ignored.

> Can I commit this to CVS (both branches, I guess) ?

This codepath is completely different in head, tho i guess the same issue will arise.

FWIW i tested the test message on the bug, and i didn't see what i would've considered any more delay than i'd expect for such a large image - 1/2 to 1 second was all to build the thumbnail.

As for the patch, what defines GNOME_THUMBNAIL_H?  Isn't it ... gnome-thumbnail.h?