Re: [Evolution-hackers] Mailing list recognition problem

[Not Zed <notzed ximian com>]

On Fri, 2003-11-28 at 16:01, Rodney Dawes wrote:
> On Mër , 2003-11-19 at 05:25, Ettore Perazzoli wrote:
> > Hi,
> > 
> > I am on a topica.com mailing list that Evolution doesn't recognize as
> > such.  (I.e. it doesn't give me an option to create a mailing list rule
> > for it.)
> > 
> > The messages do have some mailing list headers that we could use for
> > that though:
> > 
> >         List-Help:  <http://topica.com/lists/streetphoto topica com/>
> >         List-Unsubscribe:  <mailto:streetphoto-unsubscribe topica com>
> > 
> > Should we add these to the mailing list autodetection regexp list?
>
> Judging from the headers in this mail, it seems like we use X-BeenThere
> and possibly X-Loop if it appears, to do the autodetect stuff. Those
> seem to be the only ones that are really reliable for determining the
> data for the filter creation, at least, based on the Ximian and GNOME
> mailing lists that I'm on. :-/

I don't understand this comment?  We have a specific, ordered-list of things to try, and it is much longer than x-beenthere and x-loop.

I guess we should add a

"List-Unsubscribe"  -> "<mailto:(.*)-unsubscribe@(.*)>"

regex somewhere near the end of the list (too high and it might interfere with other headers).

The list-help url might not be so easy to match into a meaningful token, but at worse it doesn't have to appear to be an email address, its just a string.

I've attached a patch.  It'll probably go in when i commit the stuff i did on the plane.

 Z



Index: camel/camel-mime-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/camel-mime-utils.c,v
retrieving revision 1.198
diff -u -3 -r1.198 camel-mime-utils.c
--- camel/camel-mime-utils.c	17 Nov 2003 23:26:36 -0000	1.198
+++ camel/camel-mime-utils.c	28 Nov 2003 06:41:08 -0000
@@ -3900,6 +3900,8 @@
 	/* X-BeenThere: gnome-hackers gnome org */
 	/* X-BeenThere: gnome-hackers */
 	{ "X-BeenThere", "[ \t]*([^ ]+)@?([^ \n\t\r>]*)" },
+	/* List-Unsubscribe:  <mailto:gnome-hackers-unsubscribe gnome org> */
+	{ "List-Unsubscribe", "<mailto:(.+)-unsubscribe@([^ \n\t\r>]*)" },
 };
 
 char *
Index: camel/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.1919
diff -u -3 -r1.1919 ChangeLog
--- camel/ChangeLog	24 Nov 2003 22:38:10 -0000	1.1919
+++ camel/ChangeLog	28 Nov 2003 06:41:24 -0000
@@ -1,3 +1,18 @@
+2003-11-28  Not Zed  <NotZed Ximian com>
+
+	* camel-mime-utils.c (mail_list_magic[]): Added list-unsubscribe
+	header match.
+
+2003-11-26  Not Zed  <NotZed Ximian com>
+
+	* camel-smime-context.c (sm_verify_cmsg): take a stream rather
+	than a part for the content.
+	(sm_verify): get the content directly as a stream.
+
+	* camel-multipart-signed.c
+	(camel_multipart_signed_get_content_stream): new api to get the
+	content stream which will match the signed version.
+
 2003-11-25  Not Zed  <NotZed Ximian com>
 
 	* camel-cipher-context.c (camel_cipher_validity_envelope): change