Re: [Evolution-hackers] Deadlock in camel-gpg-context.c

[Jeffrey Stedfast <fejj ximian com>]

On Mon, 2003-04-21 at 15:42, Christophe Saout wrote:
> Am Mon, 2003-04-21 um 21.34 schrieb Jeffrey Stedfast:
> 
> > > The change itself is correct, but the EOF detection in gpg_ctx_op_step
> > > is broken (it doesn't detect an eof on the stdout pipe if no ostream
> > > exists).
> > 
> > the logic was that we were *supposed* to get a TRUST status message from
> > gpg's --status-fd, but it seems we never did.
> 
> I just tested some signatures. It really seems to be gpg not working as
> expected. Then verifying a trusted signature, everything works as
> expected...
> 
> > > The code should at least not call select over and over again when an eof
> > > condition is signalled.
> >
> > which eof signal? anyways, my patch should correct the problem.
> 
> Sorry, I didn't mean a "posix" signal, I meant when select returns
> immediately because one of the file descriptors is in the eof state. But
> I see you're working around this potential problem now.
> 
> Your patch works fine and is much cleaner than mine. Thanks.

no prob, and thanks for reporting the problem :-)

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com