poppler page range



It looks like the recent poppler api adaption to add page range for
postscript export is incorrect due to different parameters in poppler
and evince. poppler_ps_file_new expects first_page and n_pages while
ps_exporter_begin expects first_page and last_page. Don't know why this
has been implemented differently but if the api remains, a patch like
the attached one should be applied to evince.

Regards,

Jürg
-- 
Juerg Billeter <j bitron ch>
	
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evince/ChangeLog,v
retrieving revision 1.398
diff -p -u -r1.398 ChangeLog
--- ChangeLog	21 May 2005 04:48:25 -0000	1.398
+++ ChangeLog	21 May 2005 12:54:23 -0000
@@ -1,3 +1,9 @@
+2005-05-21  Juerg Billeter  <j bitron ch>
+
+	* pdf/ev-poppler.c: (pdf_document_ps_exporter_begin):
+
+	Pass correct number of pages to poppler.
+
 Sat May 21 00:21:30 2005  Jonathan Blandford  <jrb redhat com>
 
 	* shell/ev-view.c: (view_update_adjustments),
Index: pdf/ev-poppler.cc
===================================================================
RCS file: /cvs/gnome/evince/pdf/ev-poppler.cc,v
retrieving revision 1.14
diff -p -u -r1.14 ev-poppler.cc
--- pdf/ev-poppler.cc	18 May 2005 17:55:17 -0000	1.14
+++ pdf/ev-poppler.cc	21 May 2005 12:54:24 -0000
@@ -874,7 +874,8 @@ pdf_document_ps_exporter_begin (EvPSExpo
 	PdfDocument *pdf_document = PDF_DOCUMENT (exporter);
 	
 	pdf_document->ps_file = poppler_ps_file_new (pdf_document->document, filename,
-						     first_page, last_page);
+						     first_page,
+						     last_page - first_page + 1);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]